Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: version pinning #231

Merged
merged 13 commits into from
Feb 29, 2024
Merged

chore: version pinning #231

merged 13 commits into from
Feb 29, 2024

Conversation

dvdanielamoitzi
Copy link
Contributor

@dvdanielamoitzi dvdanielamoitzi commented Jan 17, 2024 •
edited
Loading

Summary of changes

  • Pinned versions in package.json and requirements.txt files
  • ⚠️ versions are aligned to the versions in ordino v14.0.0
  • checked-in yarn.lock, ignoring .venv

Additional notes for the reviewer(s)

  • As ordino is an optional dependency I have added tdp_core to the package.json. I also added it to the phovea_registry.ts (with a try/catch)
  • Ordino does not include the backend of tdp_core so added it to the requriements.txt as well
  • As I aligned the tdp_core version from the backend with the version in the frontend, the CI fails

I think all those issues can be solved by having a new release of ordino

Thanks for creating this pull request 🤗

This was referenced Jan 17, 2024
Open
Open
@dvdanielamoitzi
Copy link
Contributor Author

dvdanielamoitzi commented Jan 18, 2024 •
edited
Loading

@dvdanielamoitzi use try/catch for ordino import in phovea_registry.ts

dvdanielamoitzi and others added 5 commits January 19, 2024 08:58
@dvdanielamoitzi
change import ordino in phovea_registry
e1be7a6
@dvdanielamoitzi
use dist version
a29ab98
@thinkh
fix(registry): typo
cf32bc2
@thinkh
deps: update visyn_scripts
a81c4d6
@thinkh
fix: pyton build error
f5f51cc 
```
ERROR tdp_publicdb/tests/test_main_app.py::test_health - ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/werkzeug/urls.py)
```
@thinkh thinkh merged commit 0e62adf into develop Feb 29, 2024
2 checks passed
@thinkh thinkh deleted the version_pinning branch February 29, 2024 13:02
@thinkh thinkh mentioned this pull request Feb 29, 2024
Merged
thinkh added a commit that referenced this pull request Feb 29, 2024
@thinkh
Release 15.0.0 (#234)
8fe1c23 
## What's Changed
* feat: infer categories of categorical columns by @oltionchampari in
#229
* chore: version pinning by @dvdanielamoitzi in
#231
* deps(pip): remove werkzeug again by @thinkh in
#232
* deps: tdp_core@23.0.2 + ordino@15.0.1 by @thinkh in
#233

## New Contributors
* @dvdanielamoitzi made their first contribution in
#231

**Full Changelog**:
v14.0.1...v15.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvdanielamoitzi @thinkh