Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license and add changelog #4

Closed
wants to merge 1 commit into from
Closed

Include license and add changelog #4

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2017

No description provided.

@Fitblip
Copy link
Member

Fitblip commented Jan 17, 2018

Unless you can give me a good justification for why I need this PR I'm not going to merge it.

@Fitblip Fitblip closed this Jan 17, 2018
@ghost
Copy link
Author

ghost commented Jan 18, 2018

The tarballs at pypi (https://pypi.python.org/pypi/certstream) don't include these files if you do not specify them in the file. Both files should be bundled together with the source code.

See also the Python Packaging tutorial:
https://packaging.python.org/tutorials/distributing-packages/#license-txt

And why a changelog is useful: Because then the users of this program, other developers using it in other projects and packagers can easily see what has changes and what they need to change in their applications, libraries and packages. Otherwise they do either not take note of relevant changes or need to browse the commit history.

@ghost
Copy link
Author

ghost commented Mar 1, 2018

Any further comments on that?

@ghost
Copy link
Author

ghost commented Mar 1, 2018

@Fitblip
Copy link
Member

Fitblip commented Mar 1, 2018

@wagner-certat - not trying to sound rude or disrespectful, but these seem like very pedantic changes, which is why I closed this issue. I'm not interested in maintaining an itemized changelog past github releases since this isn't my only open source project, and this repo has a grand total of 20 commits to it.

At the end of the day, this is open source software though, if you feel strongly and want to maintain a fork that does those things, you'll hear no objection from me.

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Would it be possible to include the license in the tarball?

@Fitblip
Copy link
Member

Fitblip commented Mar 2, 2018

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant