[frontend] fix import openpgp manager #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor double declaration of `generateKey`
|
not fully verified yet |
- refactor in tsx - split forms: generate & import - fix saving pub key
|
should be fine now |
| this.state.files.map((file) => ( | ||
| <File file={file} onRemove={this.resetForm} /> | ||
| this.state.files.map((file, i) => ( | ||
| <File key={i} file={file} onRemove={this.resetForm} /> |
There was a problem hiding this comment.
No array index in key… Mais que fait eslint ? :p
There was a problem hiding this comment.
at least index is better than nothing :)
|
|
||
| {keyDetails && ( | ||
| <div className="m-openpgp-key__summary"> | ||
| <span>{keyDetails?.userIds}</span> |
There was a problem hiding this comment.
userIds are thrown as is, without separators, which is difficult to read. We may want to dive in a little bit to see how to display this in a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor double declaration of
generateKey