Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This change was made to enhance code cleanliness and efficiency in tutorial app #899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

This change was made to enhance code cleanliness and efficiency in tutorial app #899

wants to merge 1 commit into from

Conversation

ravibaghel
Copy link

List of Changes:

  1. The code line initializing a variable "c" with the instance of "SimpleContainer" has been altered. The updated code no longer assigns the instance to the variable "c", but simply gets the instance of "SimpleContainer" without storing it in any variable. This change suggests that the variable "c" was not being used elsewhere in the code, hence it was removed to improve code cleanliness and efficiency.

@ravibaghel
This change was made to enhance code cleanliness and efficiency.
cc0ccb1 
List of Changes:
1. The code line initializing a variable `c` with the instance of `SimpleContainer` has been altered. The updated code no longer assigns the instance to the variable `c`, but simply gets the instance of `SimpleContainer` without storing it in any variable. This change suggests that the variable `c` was not being used elsewhere in the code, hence it was removed to improve code cleanliness and efficiency. (Reference: Code Change 1)
vb2ae
vb2ae reviewed May 13, 2024
View reviewed changes
samples/tutorals/WPF/Wpf.Tutorial/Caliburn.Micro.Tutorial.Wpf/Bootstrapper.cs
@@ -43,7 +43,7 @@ protected override void Configure()

protected override async void OnStartup(object sender, StartupEventArgs e)
{
var c= IoC.Get<SimpleContainer>();
IoC.Get<SimpleContainer>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vb2ae vb2ae vb2ae left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravibaghel @vb2ae