fix: Property paths' object is using wrong binding #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
changed the title
group
|
@Callidon I actually found the issue; and fixed in a 2nd commit. |
|
Hi! Thank you for spotting (and fixing) this bug ^^ I've started the CI for your PR. Once all checks are green, I will merge it 👍 |
|
@Callidon it's all green 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test for something that should actually be working: I don't know what is the best way of fixing it yet, I'd love to have some guidance if possible.Fixes a bug with the property paths.
FYI @Lastshot97 as you contributed the property path engine.