perf: When property path is bound both sides, use both bindings #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
commented
Jul 2, 2021
|
|
||
| ASK WHERE { | ||
| { | ||
| :Alice foaf:knows | :hate :Bob. |
There was a problem hiding this comment.
Note: this actually doesn't test the query being made but more that it still works well.
|
Thanks for the fix, I'm merging it right away. |
|
@sroze Do you have others optimizations/bug fixes in preparation for the package? Just to know if I can publish a minor release right away, to publish your contributions, or if I need to wait for more stuff to come 😃 |
|
@Callidon so far so good, that's all I found, you can release a minor version. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, even if both sides of the property path are bound, the triple match will have one side unbound: this is a performance bottleneck, especially for large datasets.
This PR changes this.