Skip to content

Commit

Permalink
fixed bug when switching scatter options with x, y, and error set bet…
Browse files Browse the repository at this point in the history
…ween "Add Chart" and "Add New Trace"
  • Loading branch information
tgoldina committed Sep 27, 2018
1 parent 3fde917 commit 8074fee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/firefly/js/charts/ui/ChartSelectPanel.jsx
Expand Up @@ -215,7 +215,7 @@ function ChartActionOptions(props) {
const chartId = chartAction === CHART_ADDNEW ? undefined : chartIdProp;

if (chartAction === CHART_ADDNEW || chartAction === CHART_TRACE_ADDNEW) {
return (<NewTracePanel {...{groupKey, tbl_id, chartId, hideDialog, showMultiTrace}}/>);
return (<NewTracePanel key={chartAction} {...{groupKey, tbl_id, chartId, hideDialog, showMultiTrace}}/>);
}
if (chartAction === CHART_TRACE_MODIFY) {
return (
Expand Down
2 changes: 1 addition & 1 deletion src/firefly/js/ui/TargetPanelWorker.js
Expand Up @@ -186,7 +186,7 @@ function resolveObject(posFieldDef, resolver) {
}
).catch((e) => {
let feedback = `Could not resolve: ${objName}`;
if (e.name === 'AbortError') {
if (e && e.name === 'AbortError') {
feedback += '. Unresponsive service.';
} else {
feedback += '. Unexpected error.';
Expand Down

0 comments on commit 8074fee

Please sign in to comment.