DM-9371 Display cutouts in LSST timeseries viewer #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwang2016
reviewed
Mar 1, 2017
src/firefly/js/ui/SizeInputField.jsx
Outdated
| } | ||
| return (sizestr) ? convertAngle(((unit) ? unit : 'deg'), 'deg', sizestr).toString() : ''; | ||
| return (sizestr) ? toMaxFixed(convertAngle(((unit) ? unit : 'deg'), 'deg', sizestr), DECDIGIT).toString() : ''; |
There was a problem hiding this comment.
this change will lose the fidelity of user's entry. ex. if user enters 5.0000006 in unit 'deg', when user changes the unit to be 'arcmin', I think it is preferred to do the conversion based on 5.0000006 instead of 5.000001.
|
Review completes. All is good except the concern for SizeInfputField.jsx. |
|
The latest commit addressed Cindy's concern: back to no formatting when size is converted to degrees in SizeInputField.jsx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-9371
Display image cutouts in LSST TS viewer
To test, http://localhost:8080/firefly/ts.html, use LSST_SDSS and raw file attached to DM-9348
Enable option to return cutouts on image search (at the moment, DAX supports cutouts image cutouts only Science CCD Exposure table, not yet for Deep Coadd)
To test, http://localhost:8080/firefly/lsst-pdac-triview.html, select Images, set Return Image Size or leave it blank for full image.
Updated SizeInputField to allow empty values.