Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-10149 fix the phase value range of phase folded chart #357

Merged
merged 1 commit into from Apr 20, 2017

Conversation

cwang2016
Copy link
Contributor

@cwang2016 cwang2016 commented Apr 19, 2017

the development includes:

  • fixes the phase value range on the phase folded curve to be [0, 2)
  • plotly based phase folded chart doesn't react properly as the periodogram table is highlighted on a row with invalid period value.

test:

  • start time series upload page, i.e. localhost:8080/firefly/ts.html
  • load a time series file
  • select 'find period' in the result page, go to period page
  • make the zero point time value bigger by adding a couple of digit '0' before the decimal point
  • slide the slider to see if the phase falls between 0 and 2
  • click 'calculate periodogram'
  • select some period value which is either valid or invalid
  • check if the period entry and the phase folded chart react correctly.
    (valid period shows a phase folded chart, invalid period shows no chart).

@cwang2016 cwang2016 requested a review from lznakano April 19, 2017 01:43
@cwang2016 cwang2016 self-assigned this Apr 19, 2017
@cwang2016 cwang2016 changed the title DM-10149 fixed the phase value range of phase folded chart. DM-10149 fix the phase value range of phase folded chart Apr 19, 2017
@ymeiymei ymeiymei self-requested a review April 19, 2017 18:14
@ymeiymei
Copy link
Contributor

Tested:

  • started time series upload page, i.e. localhost:8080/firefly/ts.html
  • loaded a time series file (lc_raw.tbl for WISE)
  • selected 'find period' in the result page, went to period page
  • made the zero point time value bigger by adding a couple of digit '0' before the decimal point
  • slid the slider and saw the phase falling between 0 and 2.
    Suggestion: For next version, when sliding the period bar, the phase plot has fixed range[0,2].
  • clicked 'calculate periodogram'
  • selected some period value in the Period chart which is either valid or invalid (within or beyond the period range defined in the period bar)
  • checked and found the period entry and the phase folded chart react correctly:
    When the period is valid, the phase plot shows; when the period is invalid (say < 0.001), the phase plot shows nothing and the period in the period selection turns to red.

Pass with one suggestion for future fix.

@cwang2016 cwang2016 merged commit 7bedf61 into dev Apr 20, 2017
@cwang2016 cwang2016 deleted the DM-10149-PeriodogramIssues branch April 20, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants