DM-13989: FOV and cube issues #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cubes: fixed the bugs related to moving between HiPS cubes and regular hips - Cubes: honor the data_cube_* properties and show information about the 3rd dimension - Use: value = crval3 + (cubeIdx - crpix3 ) * cdelt3 - Make field of view and target optional - Use the HiPS properties if they are not specified. - If neither are specified show 180 degrees at 0,0
cwang2016
reviewed
Apr 4, 2018
| const cdelt3= Number(data_cube_cdelt3); | ||
| if (isNaN(crpix3) || isNaN(crval3) || isNaN(cdelt3)) return ''; | ||
| const value = crval3 + ( plot.cubeIdx - crpix3 ) * cdelt3; | ||
| return `${numeral(value).format('0.00000')} ${data_cube_bunit3}` |
There was a problem hiding this comment.
for cube case like 'CALIFA DR2 V500...', 'data_cube_bunit3' is undefined, and the display shows nothing.
for cube case like 'HI4PI HI Survey (individual cubes)', 'data_cube_bunit3' is defined as 'null', and the display shows 'null'. Does 'null' mean some unit in default? or could the display also show nothing instead of 'null'?
There was a problem hiding this comment.
This is because data_cube_bunit3 is the string "null". I think we are doing the right think by the standard. However, I think I will just look for the string 'null' and ignore it.
|
Works well except the minor concern added in previous comment. |
cwang2016
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the following:
value = crval3 + (cubeIdx - crpix3 ) * cdelt3To Test: