DM-14157: hips/fits/aitoff switching

[robyww]

• buttons to move between hips/fits/aitoff
• zoom switching now includes allsky in algorithm
• auto check box to switch on zoom
• zoom level switch to field of view
• fixed: FOV when image zoomed level is really small
• fixed: order of buttons
• fixed: context toolbar going away when in different context modes
• ButtonGroup option for RadioGroupInputFieldView

to test:

• do catalog search, then switch between hips and fits
• try the auto button and zoom
• do a catalog search with m4, then m1
• switch between hips, fits, aitoff
• try auto button and zoom
• try tooltip over field of view for both hips and fits
• notice that there is only field of view, not zoom level

[ejoliet]

I've tested the fixes you mentioned. I would pass the baton to Vandana or Gregory because they know the expectation from the transition feature better than me.
In that regard, i think there is probably a tweak on the fall over fov angle and other option but that's up to the scientist.
From UI point of view i don't see any other improvement to be made. The button group looks nice!

I have a comment but i'm not sure what was discussed in the past: when i'm on any of those image option Aitoff or hips or fits with a particular zoom/orientation and click 'auto' or just switch the image is back to initial zoom/orientation, seems that the image is reset every time i switch, i was surprise not to see it keeping the same orientation and zoom level. Is that a bug or is on purpose? Might want to wait for feedback on those details.

Other than that, looks good!

[cwang2016]

@trey Here are two cases I observed, needing your verification.
case 1,
do catalog search on m31
then switch the selection between HiPS and Fits, the FOV number is changed every time switching to HiPS, and FOV on FITS follows the change accordingly.

question: FOV on HiPS is changed every time when it is re-selected after FITS?

case 2,
do catalog search on m31, got HiPS image, FOV 13 arcmin
next do catalog search on m4, got HiPS image, FOV 171 deg
next do catalog search on m1, radius 100 arcsec, got aitoff
switch to HiPS, got FOV 171 deg
switch to FITS, got FOV 14 arcmin, then HiPS, got FOV 19 arcmin
switch to aitoff, then HiPS, got FOV 171 deg.

question: FOV on HiPS is different depending on if it is selected after Aitoff or FITS?

[trey]

@cwang2016 I think you have the wrong Trey. :)

[cwang2016]

Review completed. ButtonGroup works well. Just having the concern regarding FOV values as switching among HiPS/FITS/Aitoff.

[cwang2016]

@trey I push a fix to show the hips list popup with the highlighted row in sync with the hips image after catalog search.

[trey]

Still the wrong @trey. Please notify the correct Trey. I beg you.

[cwang2016]

@robyww
case 1,
do catalog search on m31
then switch the selection between HiPS and Fits, the FOV number is changed every time switching to HiPS, and FOV on FITS follows the change accordingly.

question: FOV on HiPS is changed every time when it is re-selected after FITS?

case 2,
do catalog search on m31, got HiPS image, FOV 13 arcmin
next do catalog search on m4, got HiPS image, FOV 171 deg
next do catalog search on m1, radius 100 arcsec, got aitoff
switch to HiPS, got FOV 171 deg
switch to FITS, got FOV 14 arcmin, then HiPS, got FOV 19 arcmin
switch to aitoff, then HiPS, got FOV 171 deg.

question: FOV on HiPS is different depending on if it is selected after Aitoff or FITS?

[cwang2016]

@robyww
I push a fix to show the hips list popup with the highlighted row in sync with the hips image after catalog search.

[robyww]

Thanks for the commit @cwang2016

[robyww]

@cwang2016 thanks for the testing:

case1: fixed
case2:

• This is fixed as it is similar to case 1.
• I made switching to aitoff to always go to the full image. Aitoff is very hard to match up.
• When switching from aitoff to fits it get the maximum size FITS image of the center point on the screen.
• When switching to HiPS it is similar, maximum size centered on the Aitoff center point.

So 'from Aitoff' always tries to line up the point, 'to Aitoff' always just shows the Aitoff full screen. I hope this is good enough for the users.

@ejoliet I think this fixes your issues as well.