Fix indexerror in parse_code, allow ?%help to work

Calysto · Sep 7, 2014 · 8e3ddf8 · 8e3ddf8
1 parent a1f6373
commit 8e3ddf8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/jupyter_kernel/magickernel.py b/jupyter_kernel/magickernel.py
@@ -506,15 +506,15 @@ def _parse_code(code, prefixes, suffixes, start=0, end=-1):
     pre_magics = {}
     for (name, prefix) in prefixes.items():
         pre = ''
-        while snip[len(pre)] == prefix:
+        while len(pre) < len(snip) and snip[len(pre)] == prefix:
             pre += prefix
         if pre:
             pre_magics[name] = pre
 
     post_magics = {}
     for (name, suffix) in suffixes.items():
         post = ''
-        while snip[-len(post) - 1] == suffix:
+        while len(post) < len(snip) and snip[-len(post) - 1] == suffix:
             post += suffix
         if post:
             post_magics[name] = post

diff --git a/jupyter_kernel/magics/help_magic.py b/jupyter_kernel/magics/help_magic.py
@@ -39,9 +39,12 @@ def cell_help(self, text):
     def get_help_on(self, info, level):
 
         if info['magic'] and info['magic']['name'] == 'help':
-            code = info['rest']
+            code = info['rest'].rstrip()
 
             magic_prefix = self.kernel.magic_prefixes['magic']
+            if code.endswith(magic_prefix + 'help'):
+                return self.get_help('line', 'help', level)
+
             if magic_prefix + 'help' in code:
                 while code.startswith(self.kernel.magic_prefixes['magic']):
                     code = code[1:]