Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back magics tests #261

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Add back magics tests #261

merged 2 commits into from
Dec 10, 2022

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Dec 10, 2022

The pytest configuration was recently changed from running tests in all directories except from a list of exclusions to running test only in a set of listed directories. In this change the magics tests in metakernel/magics/tests were lost. This PR puts them back.

Without the change:

============================= 40 passed in 23.08s ==============================

With the change:

======================== 79 passed, 3 skipped in 38.40s ========================

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Member

I'll make a release with this on Monday.

@blink1073 blink1073 merged commit 5ec51d6 into Calysto:main Dec 10, 2022
@ellert ellert deleted the magics-tests branch December 10, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants