Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require status checks to pass to avoid regression #599

Open
Kilo59 opened this issue Jan 8, 2019 · 2 comments
Open

Require status checks to pass to avoid regression #599

Kilo59 opened this issue Jan 8, 2019 · 2 comments

Comments

@Kilo59
Copy link
Contributor

Kilo59 commented Jan 8, 2019

I've noticed that some previous fixes have creeped back into the codebase even though the travis build was failing them.

If not already I think we ought to require the Travis CI status check to pass.
I understand that the travis builds have been quite flakey and I'm attempting to address that as well #598.

I also think this is probably a good idea before we start automating the deployment process.

image

@CamDavidsonPilon
Copy link
Owner

Thanks for the suggestion, @Kilo59. My concern is that this disrupts workflows (ex: commiting small PRs off a branch that is failing). However, this could be solved with a pre-commit hook on my side. Let me think about it a bit more.

@Kilo59
Copy link
Contributor Author

Kilo59 commented Jan 8, 2019

😄 Yeah, I totally understand the concern.
Hopefully, this PR #598 can address some (probably not all) of that.

As admin you would still be able to force things through, but it would be 1 extra step, and ONLY admins would have that power.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants