You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that some previous fixes have creeped back into the codebase even though the travis build was failing them.
If not already I think we ought to require the Travis CI status check to pass.
I understand that the travis builds have been quite flakey and I'm attempting to address that as well #598.
I also think this is probably a good idea before we start automating the deployment process.
The text was updated successfully, but these errors were encountered:
Thanks for the suggestion, @Kilo59. My concern is that this disrupts workflows (ex: commiting small PRs off a branch that is failing). However, this could be solved with a pre-commit hook on my side. Let me think about it a bit more.
I've noticed that some previous fixes have creeped back into the codebase even though the travis build was failing them.
If not already I think we ought to require the Travis CI status check to pass.
I understand that the travis builds have been quite flakey and I'm attempting to address that as well #598.
I also think this is probably a good idea before we start automating the deployment process.
The text was updated successfully, but these errors were encountered: