Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score_ -> log_likelihood #819

Closed
CamDavidsonPilon opened this issue Sep 3, 2019 · 3 comments · Fixed by #927
Closed

score_ -> log_likelihood #819

CamDavidsonPilon opened this issue Sep 3, 2019 · 3 comments · Fixed by #927

Comments

@CamDavidsonPilon
Copy link
Owner

I'm increasing like using the log-likelihood as a measure of "fit" in sample and out of sample.

At the moment, a model's score_ is the c-index, which I'm increasingly not liking.

I may consider swapping these two...

@KSafran
Copy link

KSafran commented Oct 8, 2019

IMHO this would be a good change.

Related question - why just do log-likelihood for the uncensored data. Couldn't you also calculate a likelihood for censored data using 1 - CDF? Isn't log-likelihood for uncensored points only biasing the predictions downward (due to sampling bias)?

@CamDavidsonPilon
Copy link
Owner Author

@KSafran, can you expand a bit more on your question? I am not understanding where in the code the likelihood for censored is not calculated.

@KSafran
Copy link

KSafran commented Oct 8, 2019

Ah, my bad, I was looking at the log loss metrics functions defined here, but looking at these loss functions it looks like you do account for the likelihood of right-censored values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants