Optional event_col in AAF and CPH fitters #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -267,7 +268,7 @@ def test_survival_table_from_events_raises_value_error_if_too_early_births(): | |||
| min_obs = T.copy() | |||
| min_obs[1] = min_obs[1] + 10 | |||
| with pytest.raises(ValueError): | |||
| df = survival_table_from_events(T, C, min_obs) | |||
| survival_table_from_events(T, C, min_obs) | |||
| @@ -422,7 +422,7 @@ def __init__(self, fit_intercept=True, alpha=0.95, penalizer=0.5): | |||
| self.penalizer = penalizer | |||
| assert penalizer >= 0, "penalizer must be >= 0." | |||
|
|
|||
| def fit(self, dataframe, duration_col="T", event_col="E", | |||
| def fit(self, dataframe, duration_col, event_col=None, | |||
There was a problem hiding this comment.
I like that duration_col is not assumed to be called 'T' anymore either
There was a problem hiding this comment.
👍 yea not sure why I made the decision in the first place
|
Looks good otherwise |
CamDavidsonPilon
added a commit
that referenced
this pull request
Dec 23, 2014
Optional event_col in AAF and CPH fitters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spacecowboy, this PR adds the option for the
event_colparameter (default None). If left asNone, then we assume all non-censored (similar to the kmf fitter).Also,
duration_colis now a mandatory argument.