Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] edit doc for survival_difference_at_fixed_point_in_time_test #1543

Merged

Conversation

DanBasson
Copy link
Contributor

related issue - #1446

Elaborate on survival_difference_at_fixed_point_in_time_test:

  • added image for survival plot

  • added the ability to plot point in time test in plot_survival_function

  • added output for results

note that the formatting changes in plottng.py is taken from the black playground

@CamDavidsonPilon
Copy link
Owner

This is great! Thanks @DanBasson!

Are the changes to plotting.py relevant or just lint changes?

@DanBasson
Copy link
Contributor Author

I've also added the option to insert "point_in_time" to the "plot_survival_function".

I've added the following (lines 955-957):

if "point_in_time" in kwargs:  # marker for given point
    point_in_time = kwargs["point_in_time"]
    kwargs.pop("point_in_time")

and (lines 1024-1027):

if "point_in_time" in locals():
        plot_estimate_config.ax.scatter(
            point_in_time, cls.survival_function_at_times(point_in_time)
        )

@CamDavidsonPilon
Copy link
Owner

👍 cool lgtm

@CamDavidsonPilon CamDavidsonPilon merged commit cf62c60 into CamDavidsonPilon:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants