Added a fitter_kwargs argument to k_fold_cross_validation utility function #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 4, 2015 14:55
…ction - when doing k_fold_cross_validation, the function should be able to pash in key-word arguments to the fitter - for example, for the coxph model, you should be able to pass in the strata argument
…ction - when doing k_fold_cross_validation, the function should be able to pash in key-word arguments to the fitter - for example, for the coxph model, you should be able to pass in the strata argument - updated k_fold_cross_validation docstring
| @@ -207,7 +207,6 @@ def plot_lifetimes(lifetimes, event_observed=None, birthtimes=None, | |||
| plt.scatter((birthtimes[i]) + lifetimes[i], N - 1 - i, color=c, s=30, marker=m) | |||
|
|
|||
| plt.ylim(-0.5, N) | |||
| plt.show(block=block) | |||
There was a problem hiding this comment.
is this a necessary change?
|
Cool, just a single question, otherwise lgtm! |
|
Oops! It's not relevant to the revision, I'll revise |
|
Thanks for the contribution @cosmicBboy! Merging now |
|
Awesome, thanks for developing this! survival modeling in Python is a godsend :) |
CamDavidsonPilon
added a commit
that referenced
this pull request
Dec 21, 2015
Added a fitter_kwargs argument to k_fold_cross_validation utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
able to pass in key-word arguments to the fitter
pass in the strata argument