Use setuptools #222
Merged
Use setuptools #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wow, didn't realize this. Thanks for the heads up and the PR @stevenmanton! Merging now! |
|
Me neither, I had to read about it after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like setuptools is favored over distutils and allows things like installing in develop mode, which is handing when developing/debugging a package (I use that ability frequently). Setuptools isn't in the standard Python distro, but this package already has a ton of other dependencies; it seems reasonable to assume that setuptools is installed in whatever environment lifelines is deployed.
Thanks for an awesome project! I'm working on calculating lifetimes and have already found it very valuable (even just the documentation). I'm looking forward to contributing more.