Some test improvements #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another key thing was to add the `__init__.py` file to the test directory. No coverage can be captured without it.
spacecowboy
force-pushed
the
test-improvements
branch
from
9b0d5b9
to
eb80549
Compare
| @@ -71,10 +75,10 @@ install: | |||
| fi | |||
|
|
|||
| # Build in place so we can run tests | |||
| - pip install coveralls pytest-cov | |||
| - pip install python-coveralls pytest-cov | |||
|
👌 thanks for fixing this @spacecowboy! |
|
🚢, closes #180 |
CamDavidsonPilon
added a commit
that referenced
this pull request
Mar 20, 2016
Some test improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was enabling coverage on a new project and tried some copy paste from Lifelines and probably ran into the same problems you did (I am assuming you ran into the problems ;)
Also added some new Matploblib versions to the test matrix. (Btw, 2.0 is apparently in dev)