Adding dataset GBSG2 to lifelines datasets #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original source looks to be Can you add that to the doc string? Clearly you have some R-code you would like to compare to lifelines - do you have future plans to add code for that purpose? |
|
I added that line to the docstring in the load_gbsg2() function, or did you want me to add them somewhere else (perhaps you missed that one? ) ? Yeah sort of, I'm trying to implement timeROC and integrated AUC in python. So I might be able to do a pull request for those metrics if I am successful if that is of interest ? |
|
ah, you are correct 👍
This is of interest yea, look cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEC library in R (and some other libraries) use GBSG2 as a sample dataset included in the packages. It would be awesome to have it in lifelines so that we can compare R-code and lifeline code so the results are similar.
I've looked through the PEC and other libraries and all of the seem to be GPL, and googled a lot to find the license for the actual data, but couldn't find any direct reference to it. If you for some reason think this is not open data (even though its available in several R packages) feel free to ignore this pull request and just leave comment. If so I will remove it myself as well and just keep it locally.
If its interesting, take a quick look on the code so everything looks ok :)