BUGFIX: Removing unnecessary indentation in Aalen Additve fitter #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springcoil
force-pushed
the
changing_aalen_additive
branch
from
a954623
to
26684e5
Compare
springcoil
changed the title
Removing unnecessary extra stuff from this commit Removing commit Adding comments
springcoil
force-pushed
the
changing_aalen_additive
branch
from
26684e5
to
ace9b8a
Compare
| @@ -183,11 +183,12 @@ def _fit_static(self, dataframe, duration_col, event_col=None, | |||
| relevant_individuals = (ids == id) | |||
| assert relevant_individuals.sum() == 1. | |||
|
|
|||
| # perform linear regression step. | |||
There was a problem hiding this comment.
the for loop above does nothing. I don't understand these changes
There was a problem hiding this comment.
Hmm, do you have a sketch of the algorithm for this? Now I'm confused, as it seemed that the linear regression step was causing this to hang when I ran it leading to the 4 days!!!.
|
I'm cancelling this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think related to #421 that there's an unnecessary indent in your fitter. Maybe I'm wrong, however consider this an attempt to fix it.