Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate nativescript-firebase-plugin installation guide #4

Closed
FacundoMainere opened this issue Oct 19, 2018 · 4 comments
Closed

Translate nativescript-firebase-plugin installation guide #4

FacundoMainere opened this issue Oct 19, 2018 · 4 comments

Comments

@FacundoMainere
Copy link
Contributor

FacundoMainere commented Oct 19, 2018

guia-plugin-firebase.tar.gz

and add it to the docs/

@Feyn-Man
Copy link

Hi! I've translated the markdown in the folder that you linked to italian, I have to commit it in a new folder named docs in the root?

@FacundoMainere
Copy link
Contributor Author

FacundoMainere commented Oct 20, 2018

Yes, exactly. Make a subfolder for your language like docs/Lang

Thank you!

@Feyn-Man
Copy link

I created a docs folder with Italian subfolder in which there are the 2 translation in italian for this issue and for #3. I left the images folder that you passed in the zip file above in this subfolder along with the translated file. I think that a better solution is to put the images required from the guide in an images folder inside docs or directly in the root folder and change the images path into the markdown files to this folder, so every translation refers to one folder of images instead of copying multiple times the same things.
If you agree with this change I can make this changes for the files that I've uploaded and push it to the repo.

@FacundoMainere
Copy link
Contributor Author

I agree thats better to avoid repetition. But i would keep it as you pushed it so if someone wants to make localized images in your language they can put them in there.

I will make a separate issue for this though.

Thanks a lot for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants