Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual styles not being applied in the Login page #95

Closed
sgobotta opened this issue Mar 30, 2019 · 3 comments
Closed

Visual styles not being applied in the Login page #95

sgobotta opened this issue Mar 30, 2019 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui User Interface

Comments

@sgobotta
Copy link
Member

There is a bug where fonts and color are not being applied to the /login route

image

The issue could possibly be related to the moment Auth is instanced in the Admin.vue component. We don't want to change that at the moment. Though any updates regarding this architectural desition will be referenced here.
Proposals to this issue are accepted, discussed and then ready for implementation.

@sgobotta sgobotta added bug Something isn't working good first issue Good for newcomers ui User Interface labels Mar 30, 2019
@sgobotta sgobotta added this to To do in Current Tasks Mar 30, 2019
@glmaljkovich
Copy link
Contributor

This is already fixed, right?

@sgobotta
Copy link
Member Author

sgobotta commented Sep 6, 2019

Yes and No.

Before Vuetify 2 migration styles worked using the stylus loader Vuetify used to provide. The new version of this library does not support stylues anymore, thus the styles were broken. The current solution applies css in the styles tag, which partially fixes the issue, that's mainly because the Auth is outside the Vuetify scope, we cannot use vuetify variables in this component.
I think the problem is related to a misusage of the v-app directive currently applied to the Ui component. I guess we can fix that by using this directive early in the components tree, say Admin, for example.

@sgobotta
Copy link
Member Author

Merged in #155

Current Tasks automation moved this from To do to Done Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui User Interface
Projects
Current Tasks
  
Done
Development

No branches or pull requests

2 participants