Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Long-form API documentation #53

Merged
merged 21 commits into from
Mar 27, 2024
Merged

Add Long-form API documentation #53

merged 21 commits into from
Mar 27, 2024

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Oct 20, 2023

Add long form API documentation using FORD: https://cambridge-iccs.github.io/FTorch/

  • Create GH action
  • Create GH page under ICCS
  • Add URL to repo
  • Run FORD on code
  • Add additional md pages
  • Update source with comments for FORD where missing
  • Move action to rebuild docs for main, not branch

Will close #20

@jatkinson1000
Copy link
Member Author

Currently building at https://cambridge-iccs.github.io/FTorch/
Deployment seems to be working so now need to work on docs.

@jatkinson1000 jatkinson1000 added the documentation Improvements or additions to documentation label Oct 20, 2023
@jatkinson1000
Copy link
Member Author

jatkinson1000 commented Oct 23, 2023

Suggestions for additional pages:

  • Dome pleasant documentation for the examples
  • Methods of installing libtorch/pytorch and where to find it onn the system etc - can be more verbose than README

It was also suggested that we reduce the README to make it more manageable whilst maintaining the key content there.

@ElliottKasoar
Copy link
Contributor

Can this close #5?

@TomMelt
Copy link
Contributor

TomMelt commented Oct 24, 2023

According to https://forddocs.readthedocs.io/en/latest/user_guide/writing_documentation.html#non-fortran-source-files we should be able to use FORD for the C code. Not sure how well it works though

@jatkinson1000
Copy link
Member Author

jatkinson1000 commented Oct 24, 2023

Indeed, I am looking at this locally and will push once I have something.

It could close #5 and we should certainly document the C, but we have discussed since that was opened that we are 'branding' as a Fortran API rather than a 'Fortran and C' API since C users will likely know what they are doing with binding to C++.

@ElliottKasoar
Copy link
Contributor

(Mostly a note for myself)

In the GPU section, it might be worth adding something about moving non- parameters/buffers to GPU, as I intend to do in Cambridge-ICCS/FTorch-benchmarks#27.

@jatkinson1000
Copy link
Member Author

(Mostly a note for myself)

In the GPU section, it might be worth adding something about moving non- parameters/buffers to GPU, as I intend to do in Cambridge-ICCS/FTorch-benchmarks#27.

I have added a GPU page - feel free to add to it - maybe on a branch if we want to be safe and then merge back into here.

@jwallwork23
Copy link
Contributor

As discussed offline, perhaps we could work towards getting this PR merged and open new issues for the remaining checklist items? The content here is already a really good starting point. I'd be happy to review this PR if that'd be helpful?

@jatkinson1000
Copy link
Member Author

As discussed offline, perhaps we could work towards getting this PR merged and open new issues for the remaining checklist items? The content here is already a really good starting point. I'd be happy to review this PR if that'd be helpful?

Yes, please do!

Copy link
Contributor

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great start - lots of useful content, the FORD setup seems to work well, and the webpage looks nice. I checked all the links I came across and all worked except one (see comments).

Most of my requests are fairly minor and I'd be happy to help resolving them, if that would be useful?

I wonder if something like 'User guide' might be a better heading than 'Other documentation'? Just because there's lots of useful information in there.

.github/workflows/build_docs.yml Outdated Show resolved Hide resolved
.github/workflows/build_docs.yml Outdated Show resolved Hide resolved
pages/cmake.md Outdated Show resolved Hide resolved
pages/cmake.md Outdated Show resolved Hide resolved
pages/cmake.md Outdated Show resolved Hide resolved
pages/transposing.md Outdated Show resolved Hide resolved
pages/transposing.md Outdated Show resolved Hide resolved
pages/transposing.md Outdated Show resolved Hide resolved
pages/troubleshooting.md Outdated Show resolved Hide resolved
pages/troubleshooting.md Outdated Show resolved Hide resolved
@jatkinson1000 jatkinson1000 mentioned this pull request Mar 26, 2024
@jatkinson1000
Copy link
Member Author

Thanks @jwallwork23 I think those points are all covered in recent commits, including the moving 'Other docs' to 'User Guide'.

Also updated the landing page with latest resources and modified the workflow for main in anticipation of merging.

After casting an eye over I think this is probably now good to go subject to a re-review.

@jatkinson1000
Copy link
Member Author

This will also now close #98 as I have removed/simplified large chunks of the README to point at the online documentation.

@jatkinson1000 jatkinson1000 linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link
Contributor

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for making these changes @jatkinson1000! The docs are now a great source of info for getting started, as well as covering some more advanced topics.

My only final request is very minor (see the unresolved thread above) so I'm happy to approve.

@jatkinson1000 jatkinson1000 merged commit 699522e into main Mar 27, 2024
4 checks passed
@jatkinson1000 jatkinson1000 deleted the API-docs branch March 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prune README Long-form documentation
4 participants