Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved version management from static field to service #2810

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

hurricup
Copy link
Collaborator

Class initialization pathways may cause classloading errors

Class initialization pathways may cause classloading errors
@hurricup hurricup enabled auto-merge (rebase) December 18, 2023 14:38
Copy link

Qodana for JVM

2722 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 24
Missorted modifiers 🔶 Warning 613
Unused declaration 🔶 Warning 596
Deprecated API usage 🔶 Warning 249
Missing '@Override' annotation 🔶 Warning 212
Method can be made 'void' 🔶 Warning 78
Check dependency licenses 🔶 Warning 75
Method parameter always has the same value 🔶 Warning 46
Method always returns the same value 🔶 Warning 38
Hardcoded strings 🔶 Warning 35
@NotNull/@Nullable problems 🔶 Warning 34
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 27
Class is exposed outside of its visibility scope 🔶 Warning 25
Static initialization in extension point implementations 🔶 Warning 25
Method is identical to its super method 🔶 Warning 21
Unnecessary semicolon 🔶 Warning 21
Non-platform TokenSet declared in ParserDefinition 🔶 Warning 16
Declaration can have 'final' modifier 🔶 Warning 15
Can use bounded wildcard 🔶 Warning 14
Redundant 'throws' clause 🔶 Warning 11
Field may be 'final' 🔶 Warning 8
C-style array declaration 🔶 Warning 7
'final' method in 'final' class 🔶 Warning 3
Plugin.xml dynamic plugin verification 🔶 Warning 3
Raw use of parameterized class 🔶 Warning 3
Incorrect string capitalization 🔶 Warning 2
Missing required 'lang' attribute 🔶 Warning 2
A service can be converted to a light one 🔶 Warning 2
Statement lambda can be replaced with expression lambda 🔶 Warning 1
Explicit type can be replaced with '<>' 🔶 Warning 1
Lambda can be replaced with method reference 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 505
Method can be extracted ◽️ Notice 5
Immutable collection creation can be replaced with collection factory call ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@hurricup hurricup merged commit b089c53 into master Dec 18, 2023
36 checks passed
@hurricup hurricup deleted the hurricup/handler-version-service branch December 18, 2023 15:29
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 82.09% (-0.01%) from 82.104%
when pulling ea3e38d on hurricup/handler-version-service
into c073198 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants