Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirm invoice function ambiguous unit variable #221

Merged
merged 16 commits into from Feb 20, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented Feb 20, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2023

Pull Request Test Coverage Report for Build 4225683357

  • 3 of 30 (10.0%) changed or added relevant lines in 4 files are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.6%) to 55.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/request-handlers/post-invoice-request-handler.ts 0 1 0.0%
src/controllers/invoices/get-invoice-status-controller.ts 2 7 28.57%
src/app/app.ts 0 8 0.0%
src/factories/payments-processor-factory.ts 1 14 7.14%
Files with Coverage Reduction New Missed Lines %
src/app/app.ts 1 14.04%
src/factories/payments-processor-factory.ts 1 18.67%
src/handlers/request-handlers/post-invoice-request-handler.ts 1 28.57%
src/controllers/invoices/get-invoice-status-controller.ts 2 12.0%
src/adapters/redis-adapter.ts 7 19.15%
Totals Coverage Status
Change from base Build 4219844810: -0.6%
Covered Lines: 1193
Relevant Lines: 2089

💛 - Coveralls

@socket-security
Copy link

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

@cameri cameri merged commit fd32949 into main Feb 20, 2023
@cameri cameri deleted the fix/secret_env_required branch February 20, 2023 17:15
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

7.0% 7.0% Coverage
0.0% 0.0% Duplication

github-actions bot pushed a commit that referenced this pull request Feb 20, 2023
## [1.22.5](v1.22.4...v1.22.5) (2023-02-20)

### Bug Fixes

* confirm invoice function ambiguous unit variable ([#221](#221)) ([fd32949](fd32949))
* Dockerfile.test to reduce vulnerabilities ([#196](#196)) ([eac8c50](eac8c50))
* upgrade axios from 1.2.4 to 1.2.5 ([#211](#211)) ([a390e29](a390e29))
* upgrade axios from 1.2.5 to 1.2.6 ([#215](#215)) ([e99ac5d](e99ac5d))
* upgrade pg from 8.8.0 to 8.9.0 ([#213](#213)) ([fe3726b](fe3726b))
* upgrade pg-query-stream from 4.2.4 to 4.3.0 ([#214](#214)) ([9272389](9272389))
* upgrade redis from 4.5.1 to 4.6.2 ([#212](#212)) ([86e8818](86e8818))
@github-actions
Copy link

🎉 This PR is included in version 1.22.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

brandonrobinson5060 pushed a commit to VIDA-Global/nostream that referenced this pull request Feb 22, 2023
* fix: dont crash when SECRET is not set

* docs: add semisol to contributors

* docs: improve readme

* docs: add payment info to readme

* docs: add zebedee_api_key to configuration.md

* fix: confirm_invoice unit var

* chore: remove unused code

* chore: improve error logging for payments

* chore: use  instead of changeme

* chore: fix typo

* chore: improve get invoice status ctrl

* fix: csp bug

* chore: remove rate limits

* chore: improve invoice page logging

* chore: prevent root with start_local

* chore: revert to redis 4.5.1
brandonrobinson5060 pushed a commit to VIDA-Global/nostream that referenced this pull request Feb 22, 2023
## [1.22.5](cameri/nostream@v1.22.4...v1.22.5) (2023-02-20)

### Bug Fixes

* confirm invoice function ambiguous unit variable ([cameri#221](cameri#221)) ([fd32949](cameri@fd32949))
* Dockerfile.test to reduce vulnerabilities ([cameri#196](cameri#196)) ([eac8c50](cameri@eac8c50))
* upgrade axios from 1.2.4 to 1.2.5 ([cameri#211](cameri#211)) ([a390e29](cameri@a390e29))
* upgrade axios from 1.2.5 to 1.2.6 ([cameri#215](cameri#215)) ([e99ac5d](cameri@e99ac5d))
* upgrade pg from 8.8.0 to 8.9.0 ([cameri#213](cameri#213)) ([fe3726b](cameri@fe3726b))
* upgrade pg-query-stream from 4.2.4 to 4.3.0 ([cameri#214](cameri#214)) ([9272389](cameri@9272389))
* upgrade redis from 4.5.1 to 4.6.2 ([cameri#212](cameri#212)) ([86e8818](cameri@86e8818))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants