-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI optimization #48
Conversation
Alex-DMC
commented
Apr 8, 2024
- Select the displayed name for the beautification process;
- UI optimization: unable to scroll to the bottom;
![pull_2](https://private-user-images.githubusercontent.com/38202944/320475573-e899858e-a570-4620-bb4e-d8603f256b36.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MzE4MzcsIm5iZiI6MTcyMDYzMTUzNywicGF0aCI6Ii8zODIwMjk0NC8zMjA0NzU1NzMtZTg5OTg1OGUtYTU3MC00NjIwLWJiNGUtZDg2MDNmMjU2YjM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDE3MTIxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjOWU1NGFmMTkwYzY5ZDk0NTc3MDI1MmIxNTMxY2U4ODUzMmQ4YTIzYjExYzZkMDQzOGQ2MDNhYzQyZDMzZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.McJ1P147hLN3uNkJfkZqgSR_OCQSYRKPSmdlMizRYAQ)
1. Select the displayed name for the beautification process; 2. UI optimization: unable to scroll to the bottom;
1. Loop to lock values (5s), very useful for certain consumption items.
@Alex-DMC These are great changes, thank you! I finally got a chance to sit down and test these. At first glance they look really good, the only issue I have is that it looks like every time the "timer" activates, there's an audible "ding" noise ever 5 seconds. I barely noticed it, but if I toggle the lock off, the dinging goes away. I'm looking into if there's a way to silence it. |
AH, the setValue() function literally has a playSound function in the first line. I think if we change the setValue function to something like this: And then wrap the playSound in a silence check:
And update your code to include a "true" parameter, it should disable that activation sound every 5 seconds...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tested this with a couple of games and it looks good.
the main reason i never cleaned up the process list was because folks seem to be using this plugin for non-steam games as well (but launching through steam), and it gets weird. i think your proposed changes should still be fine in those cases though.
okay i'm done reviewing this. i think if you make those slight adjustments i mentioned, i'm good with merging this. sorry for all the notifications! |
This resolves issue #22 |
LOL Yes, To verify that the function is running properly, I kept a prompt sound. |