Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added swing hook and hook gravity options #22

Open
wants to merge 1 commit into
base: 1.18-dev
Choose a base branch
from

Conversation

HughBone
Copy link

No description provided.

@CammiePone
Copy link
Owner

👀

@CammiePone
Copy link
Owner

CammiePone commented Jan 17, 2022

Okay, so messing around with it some, holy shit dude I actually really like the physics you applied to how the player moves when using a Hookshot.

Haven't done super thorough testing with all the upgrades yet, but there is one thing I would like to request before merging: can you make it so when swinging is turned on, the hookshot doesn't shorten the line, instead letting you swing freely? If the player wants to shorten it, having the player crouch would be fine as well.

@HughBone
Copy link
Author

Glad you like the physics, but I only copied the lead functionality and tweaked some values. I tried having it swing freely but unfortunately couldn't get anything that felt right.

@CammiePone
Copy link
Owner

Darn, alright. Then I'll merge soon:tm: when I'm in a bit of a better mindset to, since I need to thoroughly test things still

@ghost
Copy link

ghost commented Feb 28, 2023

I tried this out and I quite liked the gravity effect as an option. I wouldn't personally use the swinging, so I didn't give much thought about it, plus there's already a mod that covers that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants