Glues are overly complicated and aren't sending messages (although receiving them does work) #119

Closed
JonTheNiceGuy opened this Issue Aug 20, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@JonTheNiceGuy
Member

JonTheNiceGuy commented Aug 20, 2012

This needs to be tested by adding a record to gammu\inbox, receiving a DM through twitter and receiving a public message through twitter.

@JonTheNiceGuy

This comment has been minimized.

Show comment
Hide comment
@JonTheNiceGuy

JonTheNiceGuy Dec 15, 2012

Member

Started writing some unit tests to identify where this goes wrong.

Member

JonTheNiceGuy commented Dec 15, 2012

Started writing some unit tests to identify where this goes wrong.

JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue Jan 7, 2013

A few patches around Issue #119.
* Created unit tests for Gammu
* Fixed the interface name for Gammu messages - it's not
Glue_Gammu-Generic_Glue-Gammu-Provider or something like that any more!!
* Fixed some insert statements to match the database schema.
* Corrected issue where the UDH for longer SMS messages was creating a random
value for each chunk, rather than for each long message.
* Split longer messages into two insertion arrays, rather than one.
* Fixed the installer so it uses the same name for the interface throughout.
* Fixed the installer so it writes the Gammu Config file to the correct file
path.
* Added the generated Gammu config file to the .gitignore.
@JonTheNiceGuy

This comment has been minimized.

Show comment
Hide comment
@JonTheNiceGuy

JonTheNiceGuy Jan 7, 2013

Member

So, unit testing implies everything should be working right now, so I need to hook back up the dongle and check it for real. I'm not certain how I can unit test the Twitter API.

Member

JonTheNiceGuy commented Jan 7, 2013

So, unit testing implies everything should be working right now, so I need to hook back up the dongle and check it for real. I'm not certain how I can unit test the Twitter API.

JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue Sep 9, 2013

FIXED GLUES!! This closes issue #119
* Improved Object_User to pick up new functionality in
brokerByColumnSearch
* Made Glues more chatty (tells us how many of each event they return)
* Made the attend talk selector include more characters (we came in
under 60 characters with 20 characters of the talk title selected)

JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue Sep 18, 2013

Fixed Glues!! This closes issue #119
* Improved Object_User to pick up new functionality in brokerByColumnSearch
* Made Glues more chatty (tells us how many of each event they return)
* Made the attend talk selector include more characters (we came in under 60 characters with 20 characters of the talk title selected)

JonTheNiceGuy added a commit that referenced this issue Sep 18, 2013

@JonTheNiceGuy

This comment has been minimized.

Show comment
Hide comment
@JonTheNiceGuy

JonTheNiceGuy Sep 18, 2013

Member

Finished. Closed by pull request #190

Member

JonTheNiceGuy commented Sep 18, 2013

Finished. Closed by pull request #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment