Skip to content

Loading…

Glues are overly complicated and aren't sending messages (although receiving them does work) #119

Closed
JonTheNiceGuy opened this Issue · 3 comments

1 participant

@JonTheNiceGuy
CampFireManager member

This needs to be tested by adding a record to gammu\inbox, receiving a DM through twitter and receiving a public message through twitter.

@JonTheNiceGuy
CampFireManager member

Started writing some unit tests to identify where this goes wrong.

@JonTheNiceGuy JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue
@JonTheNiceGuy JonTheNiceGuy A few patches around Issue #119.
* Created unit tests for Gammu
* Fixed the interface name for Gammu messages - it's not
Glue_Gammu-Generic_Glue-Gammu-Provider or something like that any more!!
* Fixed some insert statements to match the database schema.
* Corrected issue where the UDH for longer SMS messages was creating a random
value for each chunk, rather than for each long message.
* Split longer messages into two insertion arrays, rather than one.
* Fixed the installer so it uses the same name for the interface throughout.
* Fixed the installer so it writes the Gammu Config file to the correct file
path.
* Added the generated Gammu config file to the .gitignore.
0800bc3
@JonTheNiceGuy
CampFireManager member

So, unit testing implies everything should be working right now, so I need to hook back up the dongle and check it for real. I'm not certain how I can unit test the Twitter API.

@JonTheNiceGuy JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue
@JonTheNiceGuy JonTheNiceGuy FIXED GLUES!! This closes issue #119
* Improved Object_User to pick up new functionality in
brokerByColumnSearch
* Made Glues more chatty (tells us how many of each event they return)
* Made the attend talk selector include more characters (we came in
under 60 characters with 20 characters of the talk title selected)
291d929
@JonTheNiceGuy JonTheNiceGuy added a commit to JonTheNiceGuy/cfm2 that referenced this issue
@JonTheNiceGuy JonTheNiceGuy Fixed Glues!! This closes issue #119
* Improved Object_User to pick up new functionality in brokerByColumnSearch
* Made Glues more chatty (tells us how many of each event they return)
* Made the attend talk selector include more characters (we came in under 60 characters with 20 characters of the talk title selected)
206b164
@JonTheNiceGuy
CampFireManager member

Finished. Closed by pull request #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.