Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutter switch server and client use signal #225

Merged
merged 3 commits into from
Mar 20, 2018
Merged

shutter switch server and client use signal #225

merged 3 commits into from
Mar 20, 2018

Conversation

fanmingyu212
Copy link
Contributor

Addresses #224. This change allows shutter server to update client and registry when switch status is changed.

aransfor
aransfor approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@aransfor aransfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fanmingyu212
Copy link
Contributor Author

@aransfor Thank you for the review. I am going to merge it now. Could you please also review the other PR #223 about Andor server save format change when you have time?

@fanmingyu212 fanmingyu212 merged commit 1de1e40 into master Mar 20, 2018
@fanmingyu212 fanmingyu212 deleted the mf/224_shutter_switch_use_signal branch March 20, 2018 00:23
@cromes cromes mentioned this pull request Jun 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aransfor aransfor aransfor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fanmingyu212 @aransfor