skip_authorize_resource not inheritable

[iamdriz]

Any reason why skip_authorize_resource isn't inheritable?
For example I have an ApplicationController with it in and a PagesController that inherits from ApplicationController like so:

class ApplicationController < ActionController::Base
  skip_authorize_resource
end
class PagesController < ApplicationController
  def index
  end
end

The methods inside PagesController don't skip! So PagesController isn't inheriting skip_authorize_resource.

But doing this:

class ApplicationController < ActionController::Base
  skip_authorize_resource
end
class PagesController < ApplicationController
  skip_authorize_resource #shouldn't this have been inherited from ApplicationController?

  def index
  end
end

Does work... why isn't skip_authorize_resource inherited? As I'd prefer to avoid having to add that line to all my subcontrollers if possible.

The reason for doing it is because of this issue: #390

[benkoshy]

@iamdriz hello - i could not discern the different between the two code examples. would you pls elaborate?

[iamdriz]

@BKSpurgeon Sorry forgot to add the correct code. Basically as you can see I've had to add the skip_authorize_resource to both controllers. But expected PagesController to have inherited it from ApplicationController but it doesn't.

[benkoshy]

I'll try and look into it. i can't guarantee success tho. pls bear with me.

[iamdriz]

@BKSpurgeon skip_authorize_resource basically just needs to be inheritable same as the load_and_authorize_resource methods.

[benkoshy]

@iamdriz bro gimme till the weekend i have not forgotton. then i'll tell you whether i could or couldn't do it

Ben

[iamdriz]

@BKSpurgeon You have any luck with it?

[benkoshy]

@iamdriz bro don't wait by the phone.........i've simply been inundated......i can't promise to find the solution -- i've yet to seriously look at the gem -- by Monday you'll know for sure whether i can solve it or not. i hope i can. btw can github do PMs?

[enneid]

workaround:

class ApplicationController < ActionController::Base
 def self.inherited(subclass)
      subclass.skip_authorize_resource 
    end
end

[coorasse]

is this issue solved in cancancan 2.0?

[benkoshy]

to fix would probably need a significant work around of existing code base.

[iamdriz]

@coorasse I've only tested this on CanCanCan 2.0 so I'd say not.

[kraflab]

Looks like this was already solved here: 1f78627 ?

[coorasse]

should be fixed, agree.