Include extra args in AccessDenied exceptions #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status of this PR? |
coorasse
requested changes
May 2, 2017
|
|
||
| 1.10.0 (August 28, 2014) | ||
|
|
||
| * Complete cancancan#115 - Specify authorization action for parent resources. |
There was a problem hiding this comment.
Please separate the two features in two different PR.
| @@ -376,6 +376,7 @@ class Container < Hash; end | |||
| expect(e.message).to eq("Access denied!") | |||
| expect(e.action).to eq(:read) | |||
| expect(e.subject).to eq(:foo) | |||
| expect(e.extra_args.first).to eq(1) | |||
There was a problem hiding this comment.
please add some more tests: check what is the content of extra_args in different cases (also when there is no extra_args)
|
I'd be happy to include these features but I need two different PR. Thanks for your work |
|
It's been 2 years since I submitted this PR. Unfortunately we've moved on from cancan and I don't really have time to invest in splitting this into separate pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #172