Support ActiveRecord 4.x enums

[markpmitchell]

Fixes Issue #102

ActiveRecord queries for records with enums are by integer value, not by symbol. As CanCan uses the same query syntax, the way to specify a condition based on enum values is like so:

can :read, Shape, color: Shape.colors[:blue]

While CanCan already generated the correct SQL queries for accessible_by, checks against individual objects did not work because the value of an enum attribute is a String. Therefore, the ActiveRecord 4 adapter must special case matches_condition? to convert the String to the appropriate integer before comparing against the value provided in the condition.

[confiks]

I've been bumping into this issue as well. Thanks for the fix!

[kimrgrey]

Hey, guys! What about this PR? I think it's pretty important patch because it's not possible to use cancancan with enums right now.

[nelsonwittwer]

Would love to see more support for enums in CanCanCan. In the meantime, this is what I have been doing:

can :read, ::Media, :published? => true

[kimrgrey]

@nelsonwittwer, suppose that your approach will not work with accessible_by because cancan will try to make sql query with column :published? which not exists.

[jwg2s]

👍 would love to see this get merged

[Senjai]

@jwg2s @markpmitchell I rebased your changes and pushed them to master. Thank you for your contribution! Sorry it took a while to get around to.

[coorasse]

👍

[kimrgrey]

Hey-ho! Great news! ❤️

[markpmitchell]

Thanks!

Mark Mitchell

On Oct 7, 2015, at 8:19 PM, Richard Wilson notifications@github.com wrote:

@jwg2s https://github.com/jwg2s @markpmitchell
https://github.com/markpmitchell I rebased your changes and pushed them
to master. Thank you for your contribution! Sorry it took a while to get
around to.

—
Reply to this email directly or view it on GitHub
#196 (comment)
.