Fix Rule#inspect when rule is created through a SQL array #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it is conflicting with Rails 6.0.0.rc1's sqlite3 adapter.
|
I am unsure if this spec is the best one for the case. Ideas are welcome. |
|
Hi @frostblooded , thanks for your PR. 👏 |
| ", #{@conditions.inspect}" | ||
| end | ||
|
|
||
| if with_scope? |
There was a problem hiding this comment.
@frostblooded I guess you have pushed this file by mistake.
There was a problem hiding this comment.
No. This is the actual fix of the bug. The way it was previously written, when there was an SQL array condition, the if/elsif wouldn't enter into either of the two blocks and it would "return" nil, which would make the code attempt to do a "repr += nil" and would throw an error.
coorasse
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589