Spec for json column regression #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression was added using DISTINCT for `build_relation`.
oleksii-leonov
changed the title
|
#605 could be a solution. |
This was referenced Mar 6, 2020
|
closed in #619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting 4d1f0d4
.distinctused inbuild_relation(if joins present).DISTINCT would fail when used on tables with json columns (PostgreSQL have no equality operator for type json).
Example:
ERROR: could not identify an equality operator for type json LINE 1: SELECT DISTINCT "users".* FROM ...Looks like this is regression, so added spec to cover this case.
This PR intentionally fails (TravisCI) on develop branch for postgresql adapter (due to regression).