Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Build Script, proper Maven Publishing, new workflows, Gradle Catalogue & much more #450

Merged
merged 2 commits into from Oct 19, 2022

Conversation

vanniktech
Copy link
Contributor

@vanniktech vanniktech commented Oct 19, 2022

I've tried this out in my project (by publishing into maven local):

Screen Shot 2022-10-19 at 13 45 48

I've also set up my credentials here: https://github.com/CanHub/Android-Image-Cropper/settings/secrets/actions

I copied most of the configs from either https://github.com/vanniktech/Emoji or https://github.com/vanniktech/blurhash


@Canato when merging this a snapshot version would automatically be uploaded using my coordinates. A new release would be done pushing a git tag, CI should do all of the releasing. I'd generate the changelogs using https://github.com/github-changelog-generator/github-changelog-generator

Feels a bit wrong that this is listed under canhub and using my credentials 🤷 but for the time being this should be okay.

@vanniktech vanniktech requested a review from a team as a code owner October 19, 2022 11:53
@vanniktech
Copy link
Contributor Author

@Canato so my proposal would be:

  • you review this, if everything is fine, we merge
  • then I create a 4.3.3 release under the new coordinates, while updating readme / changelogs etc

Then the real work can start

Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

Love the snapshot releases, was missing this

@vanniktech vanniktech merged commit 8b484fa into main Oct 19, 2022
@vanniktech vanniktech deleted the structure branch October 19, 2022 13:16
@vanniktech
Copy link
Contributor Author

Yeah let's hope I configured everything correctly 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants