fixed the bug that Gallery picker option is not showing

[datdescartes]

close #20 #52

Bug

Cause:

Wrong Intent for gallery

Reproduce

please refer #20

val intent = CropImage.activity()
    .setCropShape(CropImageView.CropShape.RECTANGLE)
    .setAspectRatio(1, 1)
    .setFixAspectRatio(true)
    .setGuidelines(CropImageView.Guidelines.ON)
    .setCropMenuCropButtonTitle("OK")
    .getIntent(this)
startActivityForResult(intent, 123)

How the bug was solved:

Copy the code from legacy lib

[Canato]

Thanks for the PR! really happy to see more people putting hands on to improve the library

I just worry cause this code was changed in #5 to fix another issue. And we need to be sure we didn't bought this problem back.

Could you point me of the tests/devices/OSs you did?

@ravindu1024 @akkie2016 could take a look and check if the issue returned on this version?

[datdescartes]

@Canato I have found that Android 11 requires permission to get package info.

I've updated the PR that combines the fixes in #5 and the legacy code with permission fixed.
This maybe also fix the bug that camera not show in some devices. (#52 )

The huawei line is removed as getGalleryIntents() always return notEmpty-list.

Tested in Android 11(pixel 4) and Android 7(Xperia)

[Canato]

Nice work!

Some bits, please update the CHANGELOG with

### Fixed
- [Galley option not showing](https://github.com/CanHub/Android-Image-Cropper/issues/20)
- [Camera option not showing](https://github.com/CanHub/Android-Image-Cropper/issues/52)

And remove the #20 comments, uncommenting the related code.

• CropImage.java line 156 // TODO Issue #20
• fragment_main.xml line 48 <!-- Todo Issue #20 --> and uncomment the code
• CropImageViewFragment line 75 // TODO Issue #20 and uncomment the code.

My Test

Running the sample app, after uncomment the above, if I click the image search I cannot see the galley option

Pixel 3, Android 11

Are you hitting something similar? or is working for you? Could provide some video/screen if is working? Maybe is my device issue and I can check

[Canato]

@datdescartes

[datdescartes]

@kaustubhkp Sorry, I don't have pixel 4 in my hand now. Will try it on weekend.
It seems the android Q's bug that only shows up maximum 2 items.

I have added the workaround, could you test if it works.

[Canato]

Very nice! now is working like a charm for me!

Great add to the library @datdescartes

To merge we just need to polish some bits

1. Please update the CHANGELOG with

### Fixed
- [Galley option not showing](https://github.com/CanHub/Android-Image-Cropper/issues/20)
- [Camera option not showing](https://github.com/CanHub/Android-Image-Cropper/issues/52)

2. Remove the #20 comments, uncommenting the related code.

• CropImage.java line 156 // TODO Issue #20
• fragment_main.xml line 48 <!-- Todo Issue #20 --> and uncomment the code
• CropImageViewFragment line 75 // TODO Issue #20 and uncomment the code.

3. Use the CommonVersionCheck class

• change Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q to CommonVersionCheck.INSTANCE.isAtLeastQ29()

Question:

On my test (using the sample app) after choosing a image from camera/gallery the image do not load into the screen.
I would say this is a sample bug that I need to fix later, not related to your changes and out of the scope of this PR.
But can you confirm me that you was able to load a image from camera/gallery on your tests?

[datdescartes]

Hi @Canato
I've just done the 1,2,3 above.
I have also fixed the sample bug. Confirmed that the image from picker show on screen. (Using fixed sample app)

[kaustubhkp]

@datdescartes Awesome Job...

I did some testing on Google Pixel 4 XL device and it works like charm for me

Now It shows camera, Gallery and Files option for me...I verified after cropping image it sending data inside onActivityResult as well :)

[Canato]

Solid amazing work!

If you are feeling so, join us as team member =)
https://github.com/CanHub/Android-Image-Cropper/discussions/42

Next release coming!