[FLAUTO] #243

Larpoux · 2020-03-15T10:07:24Z

OK, guys and girls.
I think I am ready for an integration inside the master branch.
The only, BIG issue not fixed is #234 . This issue is very, very serious. I had to disable the Resume feature on Diglot Korean (my own App). This is really very bad 😞 .
But I think this bug is not related to Flauto, and is already present in the actual Master branch.

@salvatore373 : Can you look to this Pull Request and tell us if you have remarks ?
@hyochan : I hope that you will like this PR and integrate it soon in the Master Branch.

…rying to return an exception as a String

Android x

…two app in the same plugin directory.

…roller was null - StartPlayerFromBuffer tested _audioState too late - Do not throw an exception when calling stopPlayer and the Player is already stopped

…was null. Return null now

…IS_STOPPED". Just stop the player silently

Larpoux · 2020-03-15T16:01:35Z

@hyochan :
Now, flutter_sound has two different modules:

The legacy flutter_sound with some improvments like some tools to control the Audio-focus
Flauto, wich adds @salvatore373 improvements .

Those two modules are completely separated. This has two benefits:

Separated functionalities means easier maintenance
The legacy flutter_sound module is totally backward compatible

My project would be to split again the legacy flutter_sound module into two different modules :

FlutterSoundRecorder
FlutterSoundPlayer
Those two functionalities are not related together, and there is no reason to have just one module.
Having two smaller modules will let the maintenance easier.

For having backward compatibility, the FlutterSoundPlayer module will be called simply FlutterSound and will inherit from flutterSoundRecorder.
But new developer will be encouraged to use the FlutterSoundRecorder module for recording.

We will have three modules :

Flauto (which inherit from `FlutterSoundPlayer)
FlutterSoundPlayer (which inherit from FlutterSoundRecorder for backward compatibility)
FlutterSoundRecorder

Then, I think it will be easier to address #232 (which has been closed by its creator, but for me this issue is still valid and interesting).

hyochan · 2020-03-15T16:10:28Z

@Larpoux @salvatore373 Thanks for your time for bringing up fabulous features. I really appreciate all your work given to flutter_sound for a long time and I'll do my best to check this PR so that your times are not wasted. I will try to finish this review in March!

Thanks again to all you wonderful people 🥇

Larpoux · 2020-03-15T17:02:58Z

Hyo, I suggest to maintain two branches :

Stable (the actual Master branch)
Master (the Flauto branch)

and merge the master branch to the stable branch if/when the master branch is accepted by the community as stable.

bsutton · 2020-03-15T21:48:48Z

Can I suggest you consider renaming the Flauto module to something like FlutterSoundPlayerV2.

The name flauto doesn't convey any useful information.

If we use my suggested naming convention then we end up with
FlutterSoundPlayer
FlutterSoundPlayerV2
FlutterSoundRecorder

Selecting the appropriate module is now easy.

Larpoux · 2020-03-18T09:27:20Z

Hyo, I suggest to maintain two branches :

Stable (the actual Master branch)

Master (the Flauto branch)

@hyochan : what do you think of this ? I think it will not give us much more maintenance work.
And it will be easier for us to split the Problem Reports between 'bug in Master Branch' and 'bug in stable branch'.

I am ready to do some maintenance and development on the Master Branch.
It will be more comfortable, for me to know that I will no break the Stable Branch.
If we do that, maybe good if I accept your invitation to be a flutter_sound maintainer. 😸

…use, canSkipForward and canSkipBackward

Larpoux · 2020-03-25T07:58:44Z

@hyochan is actually very, very busy for flutter_sound maintenance.
In the interim I suggest that we use the flauto fork.

The sources are here.

branch stable is the actual flutter_sound (V 2.1.1). This is the gamma branch.
branch beta is the new plugin with advance features (V 3.0.1). This is the beta branch.
branch master is just for the project development and not to be used. This is the alpha branch.

The flauto plugin is published. In your pub spec.yaml :

dependencies:
  flutter:
    sdk: flutter
  flauto: ^3.0.1+1

hyochan · 2020-03-25T10:02:26Z

@Larpoux Sounds nice that some of them can try newer version beforehand. I like the idea of separating the branches too. Shall we test the beta release for this plugin and further review this ongoing?

However, If you separate the pub plugin to flauto, users may get confused on what plugins to use since they are not always focusing on our work. What about just releasing this to the beta? How do you think?

hyochan

I've just done the QA and everything seems to work great! I really love it and would like to honor all of you(@Larpoux, @salvatore373, @bsutton) with all the work given to flutter_sound 🥇

Thank you so much again for all your hard work. Let's all please honor these wonderful people 💯 .

hyochan · 2020-03-25T11:41:19Z

Released 3.0.0 🎉

Larpoux and others added 30 commits January 21, 2020 17:53

OGG/OPUS support on iOS

603bf49

Small fix in README

c7f526d

Small fix in README

00d90ee

Small modifications after Hyo review

9c13a39

A notice that ffmpeg needs a minSDK 24 or later, on Android

0d5a084

Throw an exception if the native plugin return an error, instead of t…

983ec55

…rying to return an exception as a String

Compatibility with Flutter Embeded V2

00209f0

README : flutter_sound has depencie on permission_handler plugin

e4d7822

Merge with flutter_sound Master Branch

2fb9408

Merge with flutter_sound Master Branch

2b6be1f

flutter_ffmpeg LTS Release - minAndroidSdk 16 (instead of 24)

cb19658

removed .history.

9d7df43

added missing packages.

af80011

removed dependency that wasn't required.

2327a9a

removed unused import.

085417f

removed an unnecessary dependency.

fea6b6d

removed warnings and unnecessary awaits.

3fe629a

removed unused import.

00abfa7

removed code generating warnings.

a6831e3

Merge 'Android embeded V2' with flutter_sound Master branch

b54918e

Merge pull request #2 from bsutton/android-x

4ba177d

Android x

Just one example is enough. There are problems with flutter IDE when …

fb18d4d

…two app in the same plugin directory.

- There was a crash when calling onPlayerStateChanged and _playerCont…

35e09a1

…roller was null - StartPlayerFromBuffer tested _audioState too late - Do not throw an exception when calling stopPlayer and the Player is already stopped

Merge with flutter_sound Master Branch

7d27b1f

There was a crash in onRecorderStateChanged when _recorderController …

4a73fd7

…was null. Return null now

Issue 213

e479472

Do not throw an exception when startPlayer() and _audioState is not "…

478b721

…IS_STOPPED". Just stop the player silently

Sound volume with device buttons

9b0206b

Audio Focus control

da74c39

Flutter embedded V2 does not work

afc73f9

Larpoux added 7 commits March 10, 2020 05:34

Delete unwanted objects

b505545

Merge with Master branch

8b11eae

Working on Android

a0a33a9

Notifications are shown on Android

bd188f5

Icon sur le lock-screen d android

37c8e3e

Duck others on Android

2bed364

Ready for a pull request to the Master branch

29f58fa

Larpoux mentioned this pull request Mar 15, 2020

[FLAUTO] Progress bar on lock-screen #236

Closed

Icon on Android Example was incorrect. Now show the flutter_sound Logo

eacdc1f

hyochan added breaking labels Mar 15, 2020

Larpoux added 2 commits March 16, 2020 07:37

Track.albumArtAsset

b7fae36

Android < 26 must be supported

2783594

Larpoux added 2 commits March 20, 2020 19:26

Fix a bug on the lock-screen between two songs : we want to kip canPa…

640be59

…use, canSkipForward and canSkipBackward

Protection when flutter_sound is called in a bad state

e558fa5

Larpoux changed the title ~~Flauto~~ [FLAUTO] Mar 25, 2020

hyochan approved these changes Mar 25, 2020

View reviewed changes

hyochan merged commit 7d93ff6 into Canardoux:master Mar 25, 2020

hyochan mentioned this pull request Mar 25, 2020

add dispose method #248

Closed

This was referenced Mar 25, 2020

Cannot find symbol ActivityCompat.requestPermission #231

Closed

Stop/pause music that is playing in background when playing with flutter_sound #219

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLAUTO] #243

[FLAUTO] #243

Larpoux commented Mar 15, 2020

Larpoux commented Mar 15, 2020

hyochan commented Mar 15, 2020

Larpoux commented Mar 15, 2020

bsutton commented Mar 15, 2020

Larpoux commented Mar 18, 2020

Larpoux commented Mar 25, 2020

hyochan commented Mar 25, 2020 •

edited

hyochan left a comment •

edited

hyochan commented Mar 25, 2020

[FLAUTO] #243

[FLAUTO] #243

Conversation

Larpoux commented Mar 15, 2020

Larpoux commented Mar 15, 2020

hyochan commented Mar 15, 2020

Larpoux commented Mar 15, 2020

bsutton commented Mar 15, 2020

Larpoux commented Mar 18, 2020

Larpoux commented Mar 25, 2020

hyochan commented Mar 25, 2020 • edited

hyochan left a comment • edited

Choose a reason for hiding this comment

hyochan commented Mar 25, 2020

hyochan commented Mar 25, 2020 •

edited

hyochan left a comment •

edited