Flutter Modules are re-entrant (concurrency) #257
Conversation
…rying to return an exception as a String
Android x
…two app in the same plugin directory.
…roller was null - StartPlayerFromBuffer tested _audioState too late - Do not throw an exception when calling stopPlayer and the Player is already stopped
…was null. Return null now
…IS_STOPPED". Just stop the player silently
lib/track_player.dart
Outdated
| } | ||
|
|
||
| void setCallback() { | ||
| channel = const MethodChannel('xyz.canardoux.track_player'); |
There was a problem hiding this comment.
Any changes in this method channel?
@Larpoux I am currently suffering from file changes you've mentioned. I can't see any |
|
I changed the name. Now the two modules are :
But I did not changed the names of the module in Java and Objective-C. I can do that, now, if you want.
|
|
Now, there is 3 channels :
If the App uses several FlutterSoundPlayer, there is several instances of Android Andio Player and several AVAudioPlayer. All those instances are multiplexed on the channel com.dooboolab.flutter_sound_player If the App uses several FlutterSoundRecorder, there is several instances of Android Audio Recorder and several AVAudioRecorder. All those instances are multiplexed on the channel com.dooboolab.flutter_sound_recorder |
…er_sound_recorder and com.dooboolab.flutter_sound_track_player
|
OK Hyo, the 3 channel names are now correct |
|
Do you want I rename the Java modules and Objective C modules ? |
|
I really think that multiplexing all the flutter_sound instances on the 3 channels is good design. |
|
I am still seeing |
|
@Larpoux Oh sorry, you've pushed a commit just now~! I'll check that out! |
|
Ok! I've just checked this out and the file names and classes are not changed. Is this what you want? |
|
Yes, this is what I said. |
|
Better is Java Modules and ios modules have same name than dart modules |
|
I will do that after lunch |
|
Hyo, I fixed a little bug when we try 'Player seek` on iOS. Seek seems not working with TrackPlayer on Android. I think that's no problem for a current release. |
I am on fixing |
|
👍 . Great 😸 |
|
Hyo, I renamed the ios modules and Java modules. |
|
Closes for #261 |
This is a major re-design of flutter_sound architecture.
flutter_sound module is now split into :
All modules are re-entrant. It is possible to start several
FlutterPlayerand severalFlutterRecorderat the same time.Complete backward compatibility is provided by two deprecated modules :