Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance validation step #138

Merged
merged 3 commits into from Jan 19, 2018
Merged

Enhance validation step #138

merged 3 commits into from Jan 19, 2018

Conversation

willdurand
Copy link
Contributor

@willdurand willdurand commented Jan 18, 2018 •
edited

This small PR prevents the "validation" step to be repeated when the user has
not confirmed the validity of the metadata.

2018-01-18 18 04 59

jmaupetit
jmaupetit previously approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jmaupetit
Copy link
Contributor

jmaupetit commented Jan 19, 2018 •
edited

Don't forget to generate and git add/commit the required migration (failed test) since you changed the validated field description & help text:

$ bin/manage makemigrations submission

@willdurand
Copy link
Contributor Author

willdurand commented Jan 19, 2018 •
edited

ah, that's why it is failing indeed.. I was looking at Circle CI for that :(

I did not know we had to make migrations when such field parameters change.

@willdurand
Copy link
Contributor Author

just added the missing migration, sorry for that!

@jmaupetit
Copy link
Contributor

jmaupetit commented Jan 19, 2018 •
edited

I do agree that it's odd to add a migration for that… that's a requirement since few Django releases.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.343% when pulling 4563376 on validation into ab0d519 on master.

@willdurand willdurand merged commit b0328fe into master Jan 19, 2018
@willdurand willdurand deleted the validation branch January 19, 2018 09:37
@willdurand willdurand added this to the 2.0.0 — Hairy Starfish milestone Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 — Hairy Starfish
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willdurand @jmaupetit @coveralls