Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ai-service): MDL integration with View #153

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

paopa
Copy link
Member

@paopa paopa commented Apr 23, 2024

Description

This PR aims to support the indexing process to store the view in the vector store. and also, update the prompt to hint LLM to use the view to simplify the SQL.

Screenshots

image image

@paopa paopa force-pushed the feature/integrate-mdl-view branch from 7fe69a4 to 33fcd29 Compare April 25, 2024 10:15
@paopa paopa marked this pull request as ready for review April 26, 2024 07:43
@paopa paopa requested a review from cyyeh April 26, 2024 07:43
Copy link
Member

@cyyeh cyyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

I think we need to have more test cases though in the future. Also, we may need to think if there is a better way to test various MDL integration cases?

@paopa paopa merged commit 74383a0 into main Apr 29, 2024
3 checks passed
@paopa paopa deleted the feature/integrate-mdl-view branch April 29, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants