Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): Support edit Model metadata UI #172

Merged
merged 7 commits into from
Apr 30, 2024
Merged

feat(wren-ui): Support edit Model metadata UI #172

merged 7 commits into from
Apr 30, 2024

Conversation

andreashimin
Copy link
Contributor

Description

  • Support Edit Model Metadata UI
  • Adjust update metadata flow

Tasks

  • Add edit button on the top of the drawer
  • Add edit metadata modal
  • Add submit button & cancel button in modal

UI Screenshot

image

Base automatically changed from feature/model-crud-diagram to main April 29, 2024 06:05
fredalai
fredalai approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one issue, other LGTM

wren-ui/src/components/EditableWrapper.tsx Outdated Show resolved Hide resolved
@andreashimin andreashimin merged commit 96b56bd into main Apr 30, 2024
2 checks passed
@andreashimin andreashimin deleted the feature/edit-metadata branch April 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredalai fredalai fredalai approved these changes

Assignees
No one assigned
Labels
ci/ui module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreashimin @fredalai