Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wren-ui): update primary key validator for model form #176

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(wren-ui): update primary key validator for model form #176

merged 1 commit into from
Apr 30, 2024

Conversation

fredalai
Copy link
Contributor

@fredalai fredalai commented Apr 29, 2024 •
edited

Description

  • Update the validator since the primary key is not the required field
  • Allow a user to clear the primary key value

@fredalai fredalai added the module/ui UI related label Apr 29, 2024
andreashimin
andreashimin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredalai fredalai merged commit a522fe7 into main Apr 30, 2024
3 checks passed
@fredalai fredalai deleted the fix/model-ui branch May 6, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreashimin andreashimin andreashimin approved these changes

Assignees
No one assigned
Labels
module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredalai @andreashimin