Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wren-ui): Support calculated field modal UI #178

Merged
merged 14 commits into from
May 2, 2024

Conversation

andreashimin
Copy link
Contributor

Description

  • Add calculated field modal

Tasks

  • add calculated field modal
  • add calculated field table to metadata drawer
  • open calculated modal when click calculated field add icon
  • open update calculated modal when click calculated field more icon + select edit

Base automatically changed from feature/edit-metadata to main April 30, 2024 10:39
@andreashimin andreashimin force-pushed the feature/calculated-fields-modal branch from 7459d36 to d3d53ce Compare April 30, 2024 10:48
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the (Nit) suggestion, others LGTM.

wren-ui/src/components/table/BaseTable.tsx Outdated Show resolved Hide resolved
@andreashimin andreashimin force-pushed the feature/calculated-fields-modal branch from 715fdcd to 06b8dda Compare May 2, 2024 02:48
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. : D

@andreashimin andreashimin merged commit 9d7bcbc into main May 2, 2024
2 checks passed
@andreashimin andreashimin deleted the feature/calculated-fields-modal branch May 2, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants