-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wren-ui): Support calculated field modal UI #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreashimin
force-pushed
the
feature/edit-metadata
branch
from
April 30, 2024 02:43
d5f0f5f
to
636f559
Compare
andreashimin
force-pushed
the
feature/calculated-fields-modal
branch
from
April 30, 2024 02:47
2f858c3
to
c1418cb
Compare
fredalai
reviewed
Apr 30, 2024
andreashimin
force-pushed
the
feature/calculated-fields-modal
branch
from
April 30, 2024 10:48
7459d36
to
d3d53ce
Compare
andreashimin
force-pushed
the
feature/calculated-fields-modal
branch
from
April 30, 2024 10:59
d3d53ce
to
715fdcd
Compare
fredalai
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the (Nit) suggestion, others LGTM.
wren-ui/src/components/pages/modeling/metadata/ModelMetadata.tsx
Outdated
Show resolved
Hide resolved
andreashimin
force-pushed
the
feature/calculated-fields-modal
branch
from
May 2, 2024 02:48
715fdcd
to
06b8dda
Compare
fredalai
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. : D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks