Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): UI integrating API to model CRUD #185

Merged
merged 1 commit into from
May 3, 2024
Merged

feat(wren-ui): UI integrating API to model CRUD #185

merged 1 commit into from
May 3, 2024

Conversation

fredalai
Copy link
Contributor

@fredalai fredalai commented May 2, 2024

Description

UI integrating API to model CRUD

Tasks

  • Connect create model API to create a data model
  • Connect delete model API to delete model
  • Connect update model API to update model

@fredalai fredalai added the module/ui UI related label May 2, 2024
@fredalai fredalai marked this pull request as ready for review May 2, 2024 07:37
@fredalai fredalai force-pushed the feature/model-ui-integration-api branch from e570e4c to c171371 Compare May 2, 2024 07:41
@fredalai fredalai requested a review from andreashimin May 2, 2024 07:52
@fredalai fredalai force-pushed the feature/model-ui-integration-api branch from c171371 to 39ff06a Compare May 2, 2024 10:25
andreashimin
andreashimin approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except two issues, others LGTM

wren-ui/src/utils/errorHandler.tsx Outdated Show resolved Hide resolved
wren-ui/src/utils/errorHandler.tsx Outdated Show resolved Hide resolved
@fredalai fredalai force-pushed the feature/model-ui-integration-api branch from 39ff06a to 0e20233 Compare May 3, 2024 07:43
@fredalai fredalai merged commit d41aafa into main May 3, 2024
3 checks passed
@fredalai fredalai deleted the feature/model-ui-integration-api branch May 3, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreashimin andreashimin andreashimin approved these changes

Assignees
No one assigned
Labels
module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredalai @andreashimin