Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui): Column may have multiple relationships with different models #189

Merged
merged 1 commit into from
May 3, 2024

Conversation

andreashimin
Copy link
Contributor

@andreashimin andreashimin commented May 3, 2024

Description

A column may have multiple relationships with different models, so it should use map to retrieve all relations of the column

In the image below,
the orders model and payments model have a relationship but it couldn't be rendered correctly
The orders.OrderId only renders one relationship (orders.OrderId = order_items.OrderId)

But it actually has multiple relationships with different models:

  • orders.OrderId = order_items.OrderId
  • payments.OrderId = orders.OrderId
  • orders.OrderId = reviews.OrderId
image

Expected behavior

Renders all relationships of orders.OrderId

image

…lumn may has relationship with multiple model
@andreashimin andreashimin added the module/ui UI related label May 3, 2024
@andreashimin andreashimin changed the title fix(wren-ui): column relations may connect with multiple model fix(wren-ui): column relations may connect with multiple models May 3, 2024
@andreashimin andreashimin changed the title fix(wren-ui): column relations may connect with multiple models fix(wren-ui): column may has relationship with multiple models May 3, 2024
@andreashimin andreashimin changed the title fix(wren-ui): column may has relationship with multiple models fix(wren-ui): Column may have multiple relationships with difference models May 3, 2024
@andreashimin andreashimin changed the title fix(wren-ui): Column may have multiple relationships with difference models fix(wren-ui): Column may have multiple relationships with different models May 3, 2024
@andreashimin andreashimin marked this pull request as ready for review May 3, 2024 03:02
@onlyjackfrost onlyjackfrost merged commit bad0695 into main May 3, 2024
3 checks passed
@onlyjackfrost onlyjackfrost deleted the fix/diagram-relation branch May 3, 2024 03:13
@fredalai fredalai added the ci/ui label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants