Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): Integrate UI and CRUD API for relationship #196

Merged
merged 4 commits into from
May 6, 2024
Merged

feat(wren-ui): Integrate UI and CRUD API for relationship #196

merged 4 commits into from
May 6, 2024

Conversation

fredalai
Copy link
Contributor

@fredalai fredalai commented May 6, 2024 •
edited

Description

  • Integrate UI and CRUD API for relationship

Tasks

  • Add relationship GraphQL APIs
  • [API] Update transformModelRelationField for diagram API
  • UI integrating API to relationship CRUD
  • In the relationship update mode, only the relationship type can be editable
  • [API] update logger info model payload

Note: Currently using reference name.

@fredalai fredalai added module/ui UI related ci/ui labels May 6, 2024
@fredalai fredalai force-pushed the feature/relationship-ui-integration-api branch from e76db2b to a7457b3 Compare May 6, 2024 05:11
@fredalai fredalai changed the title feat(wren-ui): UI integrating API to relationship CRUD feat(wren-ui): Integrate UI and CRUD API for relationship May 6, 2024
@fredalai fredalai marked this pull request as ready for review May 6, 2024 05:52
@fredalai fredalai force-pushed the feature/relationship-ui-integration-api branch 2 times, most recently from 8cd3e76 to 2ec6f78 Compare May 6, 2024 06:25
wwwy3y3
wwwy3y3 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend LGTM

onlyjackfrost
onlyjackfrost approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the server part

andreashimin
andreashimin approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM 🤣 ⌛ 🔪

wren-ui/src/components/modals/RelationModal.tsx Outdated Show resolved Hide resolved
wren-ui/src/hooks/useRelationship.tsx Outdated Show resolved Hide resolved
@fredalai fredalai force-pushed the feature/relationship-ui-integration-api branch from 2ec6f78 to 17aeab4 Compare May 6, 2024 09:13
@fredalai fredalai merged commit 4d3f71c into main May 6, 2024
3 checks passed
@fredalai fredalai deleted the feature/relationship-ui-integration-api branch May 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwy3y3 wwwy3y3 wwwy3y3 approved these changes

@andreashimin andreashimin andreashimin approved these changes

@onlyjackfrost onlyjackfrost onlyjackfrost approved these changes

Assignees
No one assigned
Labels
ci/ui module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fredalai @wwwy3y3 @andreashimin @onlyjackfrost