Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui): Fix diagram node height calculation #197

Merged
merged 2 commits into from
May 6, 2024

Conversation

andreashimin
Copy link
Contributor

Description

The modeling page could not render after the user saved multiple views

Reason

The diagram couldn't find view data to calculate the node with the most column height

Tasks

  • Replenish views data for calculation
  • Add calculated field columns height calculation
  • Rearrange all column height config

@andreashimin andreashimin requested a review from fredalai May 6, 2024 06:54
@andreashimin andreashimin force-pushed the feature/integrate-calculated-field branch from d958b94 to 88ff352 Compare May 6, 2024 08:52
Base automatically changed from feature/integrate-calculated-field to main May 6, 2024 08:55
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin andreashimin merged commit f811d04 into main May 6, 2024
2 checks passed
@andreashimin andreashimin deleted the fix/diagram-node-height branch May 6, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants