-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(wren-ai-service): Indexing saved view into document store #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paopa
force-pushed
the
feature/indexing-saved-view
branch
from
May 8, 2024 10:53
2567f16
to
12160bf
Compare
cyyeh
reviewed
May 9, 2024
cyyeh
reviewed
May 9, 2024
paopa
force-pushed
the
feature/indexing-saved-view
branch
from
May 9, 2024 08:46
f155aea
to
eedee8e
Compare
cyyeh
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to convert the saved view into the specified format and store it in the document store. Additionally, it lays the groundwork for future functionalities where we can perform searches to retrieve past questions and answers associated with the view (this functionality will be addressed in a subsequent PR). The PR also aims to enhance modularity by extracting functions into separate components and utilizing the Haystack pipeline to manage the entire workflow.
The flow chart for the indexing process